Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress output for git command #16

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Suppress output for git command #16

merged 1 commit into from
Feb 21, 2019

Conversation

gwsii
Copy link
Member

@gwsii gwsii commented Feb 14, 2019 •
edited
Loading

Adds the silent: true option to the sh.exec call which is used to determine the currently active git branch.

This will address #15

Thanks for your consideration and providing this helpful module!

@gwsii
Suppress output for git command
8e04032 
Adds the `silent: true` option to the `sh.exec` call which is used to determine the currently active git branch.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.382% when pulling 8e04032 on gwsii:fix-branch-stdout into 0b1a23e on Nordstrom:master.

mollases
mollases approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@mollases mollases left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@tmwllc tmwllc self-requested a review February 21, 2019 17:00
@gwsii
Copy link
Member Author

gwsii commented Feb 21, 2019

Thanks, guys! Merging.

@gwsii gwsii merged commit 15bc137 into Nordstrom:master Feb 21, 2019
@gwsii
Copy link
Member Author

gwsii commented Feb 21, 2019

@mollases or @tmwllc Are either of you familiar with publishing this to NPM?

@tmwllc
Copy link
Contributor

tmwllc commented Feb 21, 2019

Yes, we use an npm library called np for this. https://www.npmjs.com/package/np. I believe you install it globally on your machine, then run it. It will install dependencies and run tests, increment the package version then publish it. Can you tell me your npm login name? I can add you as a user in npm so that you're allowed to publish.

@tmwllc
Copy link
Contributor

tmwllc commented Feb 21, 2019 •
edited
Loading

Actually it appears that I am not an owner of config-yml project in npm, so I can't add users. Admas is an owner, though. Admas can you add me as an owner for config-yml? I believe you can do this by running npm owner add tmwllc config-yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmwllc tmwllc tmwllc approved these changes

@mollases mollases mollases approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gwsii @coveralls @tmwllc @mollases